-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Table of Contents to use new color theme variables #5113
Update Table of Contents to use new color theme variables #5113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good on code/qa side of things - we should check with @lyubomir-popov on the color of the bottom border just to be sure
yes, the low contrast var is correct for all hrs but the ones at the top of sections - right above the h2s. Can we add this somewhere in the hr documentation please (separate task of course)? |
@pastelcyborg I found this page and realized we should probably make sure we keep it updated as we add theming support to these older components. It is Edit: disregard; updating this page is unneeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Done
Fixes WD-11872
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots