Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Table of Contents to use new color theme variables #5113

Merged

Conversation

pastelcyborg
Copy link
Contributor

@pastelcyborg pastelcyborg commented Jun 6, 2024

Done

  • Replaced old color variables with new color theme variables for improved theming support

Fixes WD-11872

QA

  • Open Table of Contents demo
  • Verify Table of Contents appears as expected (with slight, intentional change to bottom border color)

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

@pastelcyborg pastelcyborg self-assigned this Jun 6, 2024
@pastelcyborg pastelcyborg marked this pull request as ready for review June 6, 2024 16:17
@pastelcyborg pastelcyborg added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jun 6, 2024
Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on code/qa side of things - we should check with @lyubomir-popov on the color of the bottom border just to be sure

@lyubomir-popov
Copy link
Contributor

yes, the low contrast var is correct for all hrs but the ones at the top of sections - right above the h2s. Can we add this somewhere in the hr documentation please (separate task of course)?

@jmuzina
Copy link
Member

jmuzina commented Jun 10, 2024

@pastelcyborg I found this page and realized we should probably make sure we keep it updated as we add theming support to these older components.

It is templates/docs/settings/color-settings.md.

Edit: disregard; updating this page is unneeded

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bartaz bartaz merged commit 2434767 into canonical:main Jun 11, 2024
6 checks passed
@pastelcyborg pastelcyborg deleted the table-of-contents-color-theme-update branch June 13, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants