Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify Figma library maintainers on release #5132

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

dgtlntv
Copy link
Member

@dgtlntv dgtlntv commented Jun 12, 2024

As part of my efforts for creating a new Figma library I have added a script to the webteam bot which can be used to alert Figma library maintainers in the ~Figma library maintainers chat of changes of sources of truth. Amongst those sources of truth we need to keep track of to keep the Figma libraries up to date is of course Vanilla CSS.
This PR adds a job to the Github action that is triggered on release of a new Vanilla version and sends the sections 🚀 Features, 🐛 Bug Fixes and 🔨 Maintenance of the release notes as an alert to the bot to notify Figma library maintainers of the changes to Vanilla CSS

Additionally to these changes we would need to add the chat bots URL to the action secrets of the repository.

Fixes: WD-12092

Done

  • Add job to release action to notify Figma library maintainers

QA

  • I am not aware of a good way of QAing Github actions other than in production.

@webteam-app
Copy link

@dgtlntv dgtlntv requested a review from bartaz June 12, 2024 15:28
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
@jmuzina
Copy link
Member

jmuzina commented Jun 13, 2024

I think this is looking good. Where do we get the chat bot URL?

@bartaz
Copy link
Member

bartaz commented Jun 14, 2024

I think this is looking good. Where do we get the chat bot URL?

I got it from Max and added to repo, so it should be all set for next release.

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

On the next release we will see how it works and if it needs any adjustments.

@bartaz bartaz merged commit 48fb509 into canonical:main Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants