Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy examples combination - patterns/lists #5163

Conversation

@webteam-app
Copy link

@jmuzina jmuzina self-assigned this Jun 19, 2024
@jmuzina jmuzina mentioned this pull request Jun 19, 2024
6 tasks
@jmuzina jmuzina force-pushed the examples-combination-patterns-lists branch from abb99bb to b967411 Compare June 19, 2024 21:30
@jmuzina jmuzina marked this pull request as ready for review June 19, 2024 21:30
@@ -0,0 +1,6 @@
@import '../vanilla';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to use single standalone SCSS for all lists examples, as per forms.

@jmuzina jmuzina requested a review from bartaz June 25, 2024 15:50
@bartaz bartaz merged commit fef526c into canonical:percy-examples-combination Jun 25, 2024
3 of 4 checks passed
@jmuzina jmuzina deleted the examples-combination-patterns-lists branch June 25, 2024 17:14
jmuzina added a commit that referenced this pull request Jun 26, 2024
* patterns/lists

* spacing option in example template

* rm combined.scss (superseded by rem spacing)

* combine lists standalone styling

* rm is-dark docs from lists-middot per bartek suggestion
jmuzina added a commit that referenced this pull request Jun 27, 2024
* patterns/lists

* spacing option in example template

* rm combined.scss (superseded by rem spacing)

* combine lists standalone styling

* rm is-dark docs from lists-middot per bartek suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants