Percy examples combination - patterns/tables
#5172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
pastelcyborg
approved these changes
Jun 20, 2024
jmuzina
force-pushed
the
examples-combination-patterns-tables
branch
from
ee5cbc8
to
db177d6
Compare
bartaz
reviewed
Jun 24, 2024
| @@ -0,0 +1,7 @@ | |||
| @import '../vanilla'; | |||
| @include vf-base; | |||
There was a problem hiding this comment.
Hmm… Do we need to include this? I guess the inidividual standalone stylesheets already do it.
But, if they do, it means that at least base, and table, and possibly others, are included multiple times.
Which can be an issue by itself, as they will override each other .
There was a problem hiding this comment.
I don't have a good suggestion now, open to ideas.
One my idea is to simply create one standalone stylesheet per component, the combined one, and use it in all component examples - individual ones, and the combined one.
This way we will have one source of truth, only including what is needed once.
bartaz
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
bartaz
merged commit 4b43b14
into
canonical:percy-examples-combination
3 of 4 checks passed
jmuzina
added a commit
that referenced
this pull request
Jun 26, 2024
* patterns/tables * spacing option in example template * rm combined.scss (superseded by rem spacing) * Standalone stylesheet made more clean * combine table standalone styles --------- Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
jmuzina
added a commit
that referenced
this pull request
Jun 27, 2024
* patterns/tables * spacing option in example template * rm combined.scss (superseded by rem spacing) * Standalone stylesheet made more clean * combine table standalone styles --------- Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines
patterns/tablesexamplesQA