-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percy example combinations - patterns/search-and-filter
#5177
Merged
bartaz
merged 9 commits into
canonical:percy-examples-combination
from
jmuzina:examples-combinations-patterns-search-and-filter
Jun 26, 2024
Merged
Percy example combinations - patterns/search-and-filter
#5177
bartaz
merged 9 commits into
canonical:percy-examples-combination
from
jmuzina:examples-combinations-patterns-search-and-filter
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2024
jmuzina
force-pushed
the
examples-combinations-patterns-search-and-filter
branch
from
June 20, 2024 19:45
0d2011a
to
d50843c
Compare
pastelcyborg
approved these changes
Jun 20, 2024
templates/docs/examples/patterns/search-and-filter/_search-prompt-script.js
Outdated
Show resolved
Hide resolved
templates/docs/examples/patterns/search-and-filter/_search-prompt-script.js
Outdated
Show resolved
Hide resolved
pastelcyborg
added
Review: Code +1 (with changes)
and removed
Review: Code needed
labels
Jun 20, 2024
…earch & filter functionality to search & filter components with no search prompt)
jmuzina
force-pushed
the
examples-combinations-patterns-search-and-filter
branch
from
June 24, 2024 17:29
f2627e7
to
83cc31f
Compare
bartaz
reviewed
Jun 25, 2024
bartaz
merged commit Jun 26, 2024
18489b4
into
canonical:percy-examples-combination
3 of 4 checks passed
jmuzina
added a commit
that referenced
this pull request
Jun 26, 2024
* spacing option in example template * patterns/search-and-filter * search and filter uses spacing option * spacing option in example template * fix search prompt functionality breaking comined examples (applying search & filter functionality to search & filter components with no search prompt) * replace search and filter spacing with rems * rm combined.scss (superseded by rem spacing) * update search & filter var naming per code review * reorder search & filter combined examples
jmuzina
added a commit
that referenced
this pull request
Jun 27, 2024
* spacing option in example template * patterns/search-and-filter * search and filter uses spacing option * spacing option in example template * fix search prompt functionality breaking comined examples (applying search & filter functionality to search & filter components with no search prompt) * replace search and filter spacing with rems * rm combined.scss (superseded by rem spacing) * update search & filter var naming per code review * reorder search & filter combined examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review #5176 first as this depends on the vertical spacing introduced by #5176.
Search prompt script change
Introduces a change to the
_search-prompt-script
to make sure it is only called against search & filter components that actually have search prompt elements.Why?
Without this check, the search & filter script is also called against search & filter components that aren't meant to have the search prompt script run against it, as more search & filter components are now in the DOM. This causes errors at the
clear.addEventListener
andprompt.addEventListener
steps as those elements are not found.What's the change?
Majority of the change is tabbing/formatting. The bit that is actually changed is here:
QA