-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Switch component with new theme color variables #5185
Update Switch component with new theme color variables #5185
Conversation
Please note that I made some assumptions here due to the following:
|
If we need one, than we need one. For now I assumed focus colour has good enough contrast regardless of the theme. And yes, as you mentioned in MM, there is the Maybe it would actually be worth doing a separate PR for focus colour theming, and only then update this one? |
Switching this back to draft, since we talked about doing the |
Blocked pending #5192 |
This is once again ready for review now that #5192 has been merged. |
Code looks good, but let's rebase it now, that the percy combined examples have been merged and see how that runs. |
3961b7e
to
1a6e79a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
Done
Fixes WD-11873
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: