Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency canonicalwebteam.search to v1.4.0 #5255

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 26, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
canonicalwebteam.search ==1.3.0 -> ==1.4.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@webteam-app
Copy link

@bartaz
Copy link
Member

bartaz commented Jul 29, 2024

Fails with TypeError: build_search_view() missing 1 required positional argument: 'app'

Looks like there was a breaking change, we probably need to add app parameter to the call

https://github.com/canonical/canonicalwebteam.search

@pastelcyborg pastelcyborg self-requested a review August 1, 2024 15:13
@jmuzina
Copy link
Member

jmuzina commented Aug 1, 2024

Fails with TypeError: build_search_view() missing 1 required positional argument: 'app'

Looks like there was a breaking change, we probably need to add app parameter to the call

https://github.com/canonical/canonicalwebteam.search

I would really hope that breaking changes are not made on minor releases in future!

@jmuzina
Copy link
Member

jmuzina commented Aug 1, 2024

@pastelcyborg I made renovate rebase (maybe I didn't need to) but it lost the app param change, but I'm adding it back now

Copy link
Contributor Author

renovate bot commented Aug 1, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions Review: QA +1 Review: Code +1 Review: Percy +1 and removed Review: QA needed Review: Code needed Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 1, 2024
@pastelcyborg pastelcyborg merged commit 68cf10a into main Aug 1, 2024
14 checks passed
@pastelcyborg pastelcyborg deleted the renovate/internal branch August 1, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants