-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme accent color #5328
Theme accent color #5328
Conversation
TBH I feel like this PR was opened a bit too soon. From the conversation on the issue it doesn't seem we had a decision to theme the colour, or what new value should be. Currently the accent colour is not themed (has the same value in both themes). We could keep this funtionality, but add it to theme variables (both dark and light versions referencing the same Now, we are opening the discussion in introducing a new colour for the dark theme, which may prolong the review. |
Will close this but keep the branch around, and use it if/when the design decisions have been made |
Design has decided on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Done
Themes the accent color by adding a new dark-theme accent color.
Fixes WD-11879
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots