Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macros to npm package; rename macros to include vf_ namespace #5329

Conversation

pastelcyborg
Copy link
Contributor

@pastelcyborg pastelcyborg commented Aug 28, 2024

Done

  • Add _macros/ directory to npm package for publishing to npm
  • Rename macros to include vf_ namespace in both filename and macro name

Fixes #5322
Fixes WD-14402

QA

  • Pull down this branch
  • Run npm publish --dry-run
  • See that macro files are now included with published files

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@pastelcyborg pastelcyborg added Review: QA needed Review: Code needed Feature 🎁 New feature or request Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 28, 2024
@pastelcyborg pastelcyborg marked this pull request as ready for review August 28, 2024 16:54
@jmuzina
Copy link
Member

jmuzina commented Aug 28, 2024

Macros added to release artifact files, passing QA
Screenshot 2024-08-28 at 1 13 29 PM

releases.yml Show resolved Hide resolved
@jmuzina jmuzina added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 28, 2024
@pastelcyborg pastelcyborg changed the base branch from main to feature/expose-macros August 28, 2024 18:07
@pastelcyborg pastelcyborg merged commit f8c2147 into canonical:feature/expose-macros Aug 28, 2024
4 checks passed
@pastelcyborg pastelcyborg deleted the 5322-add-macros-to-npm-package branch August 28, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add macros directory to npm package's published files
3 participants