Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEMO]: MAAS UI List Tree Fix #5336

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Sep 4, 2024

Done

This PR includes the changes from #5270, as well as updates to the custom styling from MAAS UI so that their .p-list-tree--static can be made compatible with our changes to the list tree.

This PR should NOT be merged into Vanilla - it is purely for demonstrative purposes for MAAS UI devs.

Note: this is based on #5270, so includes its changes. The interesting stuff is this:

  // MAAS UI static tree styling (`.p-list-tree--static`)
  .p-list-tree--static {
    // Force the entire tree to be visible
    display: block !important;

    // Replace expand button with collapse button
    // This is only needed if you are running a script, like react components, that changes the `aria-hidden` of the `.p-list-tree`.
    .p-list-tree--static::before {
      @extend %list-tree-collapse-icon;
    }
  }

and the lack of toggling aria-hidden on .p-list-tree elements with JS for the maas tree example.

Screenshots

Screenshot 2024-09-04 at 6 26 00 PM

@webteam-app
Copy link

@bartaz bartaz changed the title DO NOT MERGE: MAAS UI List Tree Fix [DEMO]: MAAS UI List Tree Fix Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants