Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(skip-link): give the skip link a more modern styling #5371

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Oct 8, 2024

Done

  • Updated style for the "skip link" pattern - see comparison screenshots below.

Fixes #5356

QA

  • Open demo for the skip link pattern
  • Click inside the iframe of the example, then press SHIFT + TAB to make the skip link appear
  • Check the new appearance of the skip link

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before:

image

After:

image

@webteam-app
Copy link

@lyubomir-popov
Copy link
Contributor

LGTM

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lorumic !

@bartaz bartaz merged commit e964254 into canonical:main Oct 10, 2024
14 checks passed
@lorumic lorumic deleted the update-skiplink-style branch October 10, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give the skip link a more modern styling
4 participants