Skip to content

Commit

Permalink
chore: remove start event handler (#132)
Browse files Browse the repository at this point in the history
Co-authored-by: arturo-seijas <102022572+arturo-seijas@users.noreply.github.com>
  • Loading branch information
yanksyoon and arturo-seijas committed Oct 24, 2023
1 parent 90803fb commit 7bcad6c
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
from charms.loki_k8s.v0.loki_push_api import LogProxyConsumer
from charms.nginx_ingress_integrator.v0.nginx_route import require_nginx_route
from charms.prometheus_k8s.v0.prometheus_scrape import MetricsEndpointProvider
from ops.charm import ActionEvent, CharmBase, LeaderElectedEvent, PebbleReadyEvent, StartEvent
from ops.charm import ActionEvent, CharmBase, LeaderElectedEvent, PebbleReadyEvent
from ops.framework import EventBase, StoredState
from ops.main import main
from ops.model import (
Expand Down Expand Up @@ -147,10 +147,6 @@ def __init__(self, *args, **kwargs):
self, relation_name=self._DATABASE_RELATION_NAME, database_name=self.app.name
)

self.state.set_default(
started=False,
)

self._require_nginx_route()
self.metrics_endpoint = MetricsEndpointProvider(
self,
Expand All @@ -169,7 +165,6 @@ def __init__(self, *args, **kwargs):
)

self.framework.observe(self.on.leader_elected, self._setup_replica_data)
self.framework.observe(self.on.start, self._on_start)
self.framework.observe(self.on.uploads_storage_attached, self._reconciliation)
self.framework.observe(self.database.on.database_created, self._reconciliation)
self.framework.observe(self.database.on.endpoints_changed, self._reconciliation)
Expand All @@ -183,10 +178,6 @@ def __init__(self, *args, **kwargs):
self._on_apache_prometheus_exporter_pebble_ready,
)

def _on_start(self, _event: StartEvent):
"""Record if the start event is emitted."""
self.state.started = True

def _set_version(self, _: PebbleReadyEvent):
"""Set WordPress application version to Juju charm's app version status."""
version_result = self._run_wp_cli(
Expand Down

0 comments on commit 7bcad6c

Please sign in to comment.