Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DB static config #106

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Remove DB static config #106

merged 3 commits into from
Aug 14, 2023

Conversation

gtrkiller
Copy link
Contributor

Remove the possibility to configure the DB with Juju config options and force the charm to use relation data.

yanksyoon
yanksyoon previously approved these changes Aug 11, 2023
Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick :D LGTM!

tests/unit/conftest.py Outdated Show resolved Hide resolved
jdkandersson
jdkandersson previously approved these changes Aug 11, 2023
Copy link
Contributor

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after comment from @yanksyoon is resolved

@gtrkiller gtrkiller dismissed stale reviews from jdkandersson and yanksyoon via a930e3d August 11, 2023 12:55
@github-actions
Copy link
Contributor

Test coverage for 6eeb190

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          514     40    160     27    89%   199-202, 340-341, 553, 584, 630, 665-666, 717-724, 729, 831, 836-837, 909, 916, 1008, 1017, 1029, 1050, 1059, 1078, 1082, 1111, 1164, 1296, 1318, 1325->1327, 1366->exit, 1378, 1395-1397, 1415, 1424-1425
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 561     41    162     28    90%

Static code analysis report

Run started:2023-08-14 13:03:31.035278

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4152
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@gtrkiller gtrkiller merged commit e4e48f1 into main Aug 14, 2023
23 checks passed
@gtrkiller gtrkiller deleted the remove_db_static branch August 14, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants