Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused StoredState #173

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove unused StoredState #173

merged 1 commit into from
Nov 27, 2023

Conversation

mthaddon
Copy link
Contributor

Applicable spec: N/A

Overview

Remove unused references to StoredState.

Rationale

The charm was no longer using StoredState but still had references to it.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@mthaddon mthaddon requested a review from a team as a code owner November 24, 2023 14:47
@mthaddon mthaddon added the trivial This is a trivial PR label Nov 24, 2023
Copy link
Contributor

Test coverage for b9f7a89

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          529     41    172     31    89%   184-187, 351-352, 552, 583, 589, 634, 669-670, 721-728, 733, 835->840, 839, 841, 846-847, 907, 925, 932, 1022, 1031, 1043, 1064, 1073, 1092, 1096, 1125, 1178, 1310, 1332, 1339->1341, 1384->exit, 1396, 1412, 1449, 1458-1459
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          16      0      0      0   100%
---------------------------------------------------------------
TOTAL                 577     42    174     32    90%

Static code analysis report

Run started:2023-11-24 14:53:30.557710

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4274
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@mthaddon mthaddon merged commit c184221 into main Nov 27, 2023
35 checks passed
@mthaddon mthaddon deleted the remove-stored-state branch November 27, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants