Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to Capacitor v6 #59

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat!: upgrade to Capacitor v6 #59

merged 1 commit into from
Apr 17, 2024

Conversation

tafelnl
Copy link
Member

@tafelnl tafelnl commented Apr 17, 2024

Just ran npx @capacitor/plugin-migration-v5-to-v6@latest

If your interest has shifted from this project, I can incorporate this project into the capacitor community plugins if you allow me

Just ran `npx @capacitor/plugin-migration-v5-to-v6@latest`
@Nodonisko Nodonisko merged commit 61d3af7 into capacitor-community:master Apr 17, 2024
@Nodonisko
Copy link
Collaborator

Thanks for PR!

I am not longer developing for Capacitor so feel free to move it.

@tafelnl
Copy link
Member Author

tafelnl commented Apr 18, 2024

Thanks for your efforts for the community so far! Would you mind to add me as an admin to this repository, so I can transfer ownership of this repository to https://github.com/capacitor-community?

@EinfachHans
Copy link

That would be awesome!

@Nodonisko
Copy link
Collaborator

Let's do that!

@tafelnl
Copy link
Member Author

tafelnl commented Apr 19, 2024

Thanks! I see now, it's not possible to grant admin access to other users for user owned repositories (as opposed to organization owned repositories) 😅 (source) Would you be able to transfer the repository to my personal account? Then, consequently, I can transfer it to the capacitor-community organization. Otherwise I would have to ask someone at Capacitor to grant you write-rights to the organization, which will probably take some time

@tibimunteanu
Copy link

@tafelnl I need to use this plugin with capacitor 6.

  • Is it possible for you to update the package on npm to include this PR so we don't have to wait until the repo is transferred?

  • Does this PR also upgrade the ios part to capacitor 6?

Thank you for taking interest in this!

@tafelnl
Copy link
Member Author

tafelnl commented Apr 19, 2024

Is it possible for you to update the package on npm to include this PR so we don't have to wait until the repo is transferred?

I don't have access to his npm account, so that's not possible for me. I can only publish once it's transferred to the organization

Does this PR also upgrade the ios part to capacitor 6?

Yes! But it doesn't add support for SPM yet, if that's what you're getting at

@EinfachHans
Copy link

@tafelnl looks like you are owner of this repository now, would love to see this transfered to capacitor plugins

@tafelnl
Copy link
Member Author

tafelnl commented Apr 22, 2024

I renamed the package to @capacitor-community/in-app-review and published a new version (v6.0.0) to npm

@tafelnl
Copy link
Member Author

tafelnl commented May 8, 2024

@Nodonisko I'm sorry to bother you one last time. But could you please run this command:

npm deprecate capacitor-rate-app "Package no longer supported. Please migrate to `@capacitor-community/in-app-review` for continued support and updates."

By executing this command a deprecation message will be displayed on the npm page of the 'old' package. I think this will make it easier for current and future users to be aware of the required migration step

It will look a bit like this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants