fix(functions): callByUrl method on Android (#673)

* fix callByUrl method * fix format
capawesome-team · Jul 5, 2024 · 5d918e4 · 5d918e4
1 parent 3aec743
commit 5d918e4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/...src/main/java/io/capawesome/capacitorjs/plugins/firebase/functions/FirebaseFunctions.java b/...src/main/java/io/capawesome/capacitorjs/plugins/firebase/functions/FirebaseFunctions.java
@@ -6,6 +6,7 @@
 import io.capawesome.capacitorjs.plugins.firebase.functions.classes.options.CallByUrlOptions;
 import io.capawesome.capacitorjs.plugins.firebase.functions.classes.results.CallResult;
 import io.capawesome.capacitorjs.plugins.firebase.functions.interfaces.NonEmptyResultCallback;
+import java.net.URL;
 
 public class FirebaseFunctions {
 
@@ -37,11 +38,11 @@ public void callByName(@NonNull CallByNameOptions options, @NonNull NonEmptyResu
     }
 
     public void callByUrl(@NonNull CallByUrlOptions options, @NonNull NonEmptyResultCallback callback) {
-        String url = options.getUrl();
+        URL url = options.getUrl();
         Object data = options.getData();
 
         getFirebaseFunctionsInstance(null)
-            .getHttpsCallable(url)
+            .getHttpsCallableFromUrl(url)
             .call(data)
             .addOnSuccessListener(
                 task -> {

diff --git a/...o/capawesome/capacitorjs/plugins/firebase/functions/classes/options/CallByUrlOptions.java b/...o/capawesome/capacitorjs/plugins/firebase/functions/classes/options/CallByUrlOptions.java
@@ -1,19 +1,21 @@
 package io.capawesome.capacitorjs.plugins.firebase.functions.classes.options;
 
 import androidx.annotation.NonNull;
+import java.net.MalformedURLException;
+import java.net.URL;
 
 public class CallByUrlOptions extends CallOptions {
 
     @NonNull
-    private String url;
+    private URL url;
 
-    public CallByUrlOptions(@NonNull String url, Object data) {
+    public CallByUrlOptions(@NonNull String url, Object data) throws MalformedURLException {
         super(data);
-        this.url = url;
+        this.url = new URL(url);
     }
 
     @NonNull
-    public String getUrl() {
+    public URL getUrl() {
         return url;
     }
 }