-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding migration servers #168
Allow overriding migration servers #168
Conversation
Excellent work! ✨ |
0a92310
to
699462c
Compare
Thanks for a quick feedback! I've amended |
Thanks for the PR! 🙇 |
Allow overriding migration servers
Can we have a 1.1.7 release for this please? Would be very appreciated :) |
I would be happy to, but I don't have gem publishing rights. For that you will need to get the attention of @kirs. |
@kirs Can we have a 1.1.7 release for this please? Would be very appreciated :) |
Pushed 1.1.7. Thank you for the PR! I tried adding @mattbrictson as an owner but his email on Github is hidden and all it provides is |
This just worked like a charm. Thanks to all involved! |
This would enable users to run migrations on multiple servers. I've seen this being discussed at capistrano/capistrano#1449.
Unlike #127, it doesn't change the existing functionality. And unlike #126 it actually works.
In our case, we would be able to override the
migration_servers
value withset :migration_servers, -> { release_roles(fetch(:migration_role)) }