Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding migration servers #168

Merged

Conversation

aliismayilov
Copy link
Contributor

This would enable users to run migrations on multiple servers. I've seen this being discussed at capistrano/capistrano#1449.

Unlike #127, it doesn't change the existing functionality. And unlike #126 it actually works.

In our case, we would be able to override the migration_servers value with set :migration_servers, -> { release_roles(fetch(:migration_role)) }

@mattbrictson
Copy link
Member

Excellent work! ✨
Can you add a mention of this new feature under the "master" heading of the CHANGELOG?

@aliismayilov
Copy link
Contributor Author

Thanks for a quick feedback! I've amended CHANGELOG changes.

@mattbrictson
Copy link
Member

Thanks for the PR! 🙇

@Bertg
Copy link

Bertg commented Jun 7, 2016

Can we have a 1.1.7 release for this please? Would be very appreciated :)

@mattbrictson
Copy link
Member

I would be happy to, but I don't have gem publishing rights. For that you will need to get the attention of @kirs.

@Bertg
Copy link

Bertg commented Jun 10, 2016

@kirs Can we have a 1.1.7 release for this please? Would be very appreciated :)

@kirs
Copy link
Member

kirs commented Jun 10, 2016

Pushed 1.1.7. Thank you for the PR!

I tried adding @mattbrictson as an owner but his email on Github is hidden and all it provides is mattbrictson@users.noreply.github.com.

@gregblass
Copy link

This just worked like a charm. Thanks to all involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants