Handle arrays in normalize_asset_timestamps #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assets = fetch(:normalize_asset_timestamps) | ||
| if assets | ||
| assets = fetch(:normalize_asset_timestamps, []) | ||
| assets = [assets] unless assets.respond_to?(:any?) |
There was a problem hiding this comment.
Would this be cleaner?
assets = Array(assets)There was a problem hiding this comment.
Learn something new every day… I like that. Fixed.
|
Thanks for PR! I hadn't realized that the README example was completely broken (I don't use the Let me know what you think of my code suggestion in the line comment. Otherwise this needs a CHANGELOG entry and then it's good to merge! |
|
Changelog entry added. This should be good to go. |
sbonami
added a commit
to sb-archive/capistrano-rails
that referenced
this pull request
Sep 13, 2016
…ride-setting * upstream/master: (24 commits) Preparing v1.1.8 Bring README up to date Handle arrays in normalize_asset_timestamps (capistrano#185) Updated configuration to avoid setting migration servers and improved recommendation Added recommendations section Remove duplicate explanations of :migration_role in README.md Your contribution goes here Add 1.1.7 release notes Prepare for 1.1.7 Fix code on README Allow overriding migration servers call Array#uniq to remove duplicated :linked_dirs Complete installation instructions Prepare for 1.1.6 Changelog for capistrano#133 /cc @januszm Moving capistrano related gems under the dev group Update changelog Update changelog Escape [ and ] when calling assets:clean rake task add clobber assets ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the Readme describes usages like so:
Yet as seen in #184, this doesn't actually work.
This PR tries to fix this case.