Explicitly require base64 to fix missing constant with net-ssh 7.2.2+ #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
force-pushed
the
require-base64
branch
2 times, most recently
from
73ec4d8
to
d208139
Compare
mattbrictson
force-pushed
the
require-base64
branch
from
d208139
to
7a77776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sshkit needs
Base64for its implementation of the known hosts file parser.Before, we were relying on net-ssh to load Base64 for us. But starting in net-ssh 7.2.2 (which was yanked), net-ssh no longer depends on the base64 gem. That means sshkit can no longer assume it will be present and loaded.
This PR fixes compatibility with net-ssh 7.2.2+ by doing the following:
require "base64"to ensure theBase64constant is definedbase64as a runtime dependency so that the library is guaranteed to be presentFixes #531