Implement streaming #517
Merged
Implement streaming #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates code generation for methods declared with `-> stream`. For Server traits, these methods have no `Results` parameter. For `Client` objects, the methods go through a new `StreamingRequest` object. Twoparty RPC connections get a fixed window size that can be configured via `twoparty::VatNetwork::set_window_size()`. The implementation closely follows capnproto-c++. One important difference: in capnproto-c++ streaming methods are delivered one-by-one, without overlap. In Rust, overlapping method calls are less error-prone, so we don't bother with that extra built-in logic. Adds a new example `streaming` that performs streaming method calls on a capability returned early via set_pipeline().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates code generation for methods declared with
-> stream. For Server traits, these methods have noResultsparameter. ForClientobjects, the methods go through a newStreamingRequestobject.Twoparty RPC connections get a fixed window size that can be configured via
twoparty::VatNetwork::set_window_size().The implementation closely follows capnproto-c++. (See capnproto/capnproto#825.)
One important difference: in capnproto-c++ streaming methods
are delivered one-by-one, without overlap. In Rust, overlapping method calls are less error-prone, so we don't bother with that extra built-in logic.
Adds a new example
streamingthat performs streaming method calls on a capability returned early via set_pipeline().