Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#1342] Make DOMTokenList iterable #1365

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: [#1342] Make DOMTokenList iterable #1365

merged 1 commit into from
Mar 25, 2024

Conversation

silverwind
Copy link
Contributor

Fixes: #1342

@silverwind
Copy link
Contributor Author

Test failures look unrelated.

capricorn86
capricorn86 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @silverwind! 🌟

@capricorn86 capricorn86 merged commit ee51a80 into capricorn86:master Mar 25, 2024
4 checks passed
@silverwind silverwind deleted the iterable branch March 25, 2024 22:48
@silverwind silverwind mentioned this pull request Mar 25, 2024
Merged
@silverwind
Copy link
Contributor Author

Thanks. Can confirm this is working downstream as well.

silverwind added a commit to go-gitea/gitea that referenced this pull request Mar 26, 2024
@silverwind
Update JS any PY dependencies, remove workarounds (#30085)
c1ac721 
- Update dependencies via `make update-js update-py svg`
- Remove `postcss` workaround -
postcss/postcss#1914
- Remove `happy-dom` workaround -
capricorn86/happy-dom#1365.
- Tested Katex and Asciinema
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Mar 30, 2024
@silverwind @earl-warren
Update JS any PY dependencies, remove workarounds (#30085)
f77922c 
- Update dependencies via `make update-js update-py svg`
- Remove `postcss` workaround -
postcss/postcss#1914
- Remove `happy-dom` workaround -
capricorn86/happy-dom#1365.
- Tested Katex and Asciinema

(cherry picked from commit c1ac72150885b327f56ea61273e27b16d6da5435)
@TreyVigus TreyVigus mentioned this pull request Apr 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOMTokenList should be iterable
2 participants
@silverwind @capricorn86