Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosync - Refreshed #1831

Closed
wants to merge 6 commits into from
Closed

Conversation

FlyGoat
Copy link

@FlyGoat FlyGoat commented Jan 25, 2022

This work is based on #1803.

Note that only MIPS is included in this PR. As that's the arch which I most familiar.

I'll work on RISC-V, sparc and others after got this portion merged.

Yes, we will have more groups.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Just derived from llvm's lib/MC/MCInstPrinter.cpp.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Documents and code, with slight fixes.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
@FlyGoat
Copy link
Author

FlyGoat commented Jan 25, 2022

\cc @XVilka @kabeor

@kabeor
Copy link
Member

kabeor commented Jan 25, 2022

@FlyGoat I will create a new branch for this feature tomorrow and plz rebase after that

@XVilka
Copy link
Contributor

XVilka commented Jan 26, 2022

Were there any changes required on the TableGen backend side?

Since this code is autogenerated, I suspect it might

@kabeor
Copy link
Member

kabeor commented Jan 26, 2022

@FlyGoat FlyGoat changed the base branch from next to autosync January 26, 2022 13:08
@FlyGoat
Copy link
Author

FlyGoat commented Jan 26, 2022

plz rebase to https://github.com/capstone-engine/capstone/tree/autosync branch

Done

Were there any changes required on the TableGen backend side?

No actually I started with files generated by Phosphorus15.

@FlyGoat
Copy link
Author

FlyGoat commented Feb 5, 2022

Any update?

@kabeor
Copy link
Member

kabeor commented Feb 6, 2022

@FlyGoat hi,as I mentioned in #1803 (comment), plz "do not add any .inc file in this PR, we should PR that alone".
Besides plz create a new pr to rebase llvm to released version first, then merge this pr.

@kabeor
Copy link
Member

kabeor commented Feb 6, 2022

I think it's better if we can auto generate .inc files and releasing by github action

@XVilka
Copy link
Contributor

XVilka commented Feb 23, 2022

@FlyGoat how is it going? Do you need any help?

@FlyGoat
Copy link
Author

FlyGoat commented Feb 23, 2022

Ah my fault, I thought I had updated PR but actually not. Will push tomorrow.

Sorry.

@kabeor
Copy link
Member

kabeor commented Feb 27, 2022

@FlyGoat Any update?

@FlyGoat
Copy link
Author

FlyGoat commented Feb 28, 2022

@kabeor sorry for the latency, PR sent on llvm-capstone repo.

@FlyGoat
Copy link
Author

FlyGoat commented Feb 28, 2022

Btw it seems impossible to sepreate code change and auto generated table change without breaking build between them.

@XVilka
Copy link
Contributor

XVilka commented Mar 27, 2022

@FlyGoat I think then splitting the change into two sets of commits - one without autogenerated files that breaks the build and the second with updated autogenerated files that fix the build. @kabeor what do you think about this approach? It will make the review easier as well.

@kabeor
Copy link
Member

kabeor commented Mar 27, 2022

@XVilka yeah,agree with that

@XVilka
Copy link
Contributor

XVilka commented May 5, 2022

@FlyGoat how is it going?

@Rot127
Copy link
Collaborator

Rot127 commented Aug 8, 2022

Just as notification: #1803 (comment)

@XVilka
Copy link
Contributor

XVilka commented May 4, 2023

Probably could be closed in favor of #1949
@kabeor

@kabeor kabeor closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants