Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2101 - Install cs_operand.h as a public header file #2103

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Jul 21, 2023

closes #2101

@XVilka
Copy link
Contributor

XVilka commented Jul 21, 2023

@trufae take a look please

@kabeor
Copy link
Member

kabeor commented Jul 21, 2023

Thanks.

@kabeor kabeor merged commit 08df8b1 into capstone-engine:next Jul 21, 2023
@trufae
Copy link
Contributor

trufae commented Jul 22, 2023

I can confirm the fix thanks! but the CI is showing some unrelated warnings that should be fixed too

 CC      cstool_arm.o
cstool_arm.c: In function ‘print_insn_detail_arm’:
cstool_arm.c:67:45: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘int64_t’ {aka ‘long int’} [-Wformat=]
   67 |     printf("\t\toperands[%u].type: P-IMM = %u\n", i, op->imm);
      |                                            ~^        ~~~~~~~
      |                                             |          |
      |                                             |          int64_t {aka long int}
      |                                             unsigned int
      |                                            %lu
cstool_arm.c:70:45: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘int64_t’ {aka ‘long int’} [-Wformat=]
   70 |     printf("\t\toperands[%u].type: C-IMM = %u\n", i, op->imm);
      |                                            ~^        ~~~~~~~
      |                                             |          |
      |                                             |          int64_t {aka long int}
      |                                             unsigned int
      |                                            %lu
  CC      cstool_tms320c64x.o
  CC      cstool.o
  CC      cstool_mos65xx.o
  CC      cstool_x86.o
  CC      cstool_sh.o
  CC      cstool_wasm.o
  CC      cstool_systemz.o
  CC      cstool_mips.o
  LINK    cstool
make[1]: Leaving directory '/home/runner/work/radare2/radare2/capstone/cstool'
make -C tests
make[1]: Entering directory '/home/runner/work/radare2/radare2/capstone/tests'
  CC      test_basic.o
  CC      test_detail.o
  CC      test_skipdata.o
  CC      test_iter.o
  CC      test_customized_mnem.o
  CC      test_arm.o
  CC      test_arm64.o
  CC      test_m68k.o
test_arm.c: In function ‘print_insn_detail’:
test_arm.c:58:45: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘int64_t’ {aka ‘long int’} [-Wformat=]
   58 |     printf("\t\toperands[%u].type: IMM = 0x%x\n", i, op->imm);
      |                                            ~^        ~~~~~~~
      |                                             |          |
      |                                             |          int64_t {aka long int}
      |                                             unsigned int
      |                                            %lx
test_arm.c:85:45: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘int64_t’ {aka ‘long int’} [-Wformat=]
   85 |     printf("\t\toperands[%u].type: P-IMM = %u\n", i, op->imm);
      |                                            ~^        ~~~~~~~
      |                                             |          |
      |                                             |          int64_t {aka long int}
      |                                             unsigned int
      |                                            %lu
test_arm.c:88:45: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘int64_t’ {aka ‘long int’} [-Wformat=]
   88 |     printf("\t\toperands[%u].type: C-IMM = %u\n", i, op->imm);
      |                                            ~^        ~~~~~~~
      |                                             |          |
      |                                             |          int64_t {aka long int}
      |                                             unsigned int
      |                                            %lu

@Rot127 Rot127 deleted the fix-header-include branch July 22, 2023 08:48
@Rot127
Copy link
Collaborator Author

Rot127 commented Jul 22, 2023

@trufae #2109

@trufae
Copy link
Contributor

trufae commented Jul 22, 2023

That was fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cs_operand.h outside the include directory, not installed
4 participants