By default compile as universal2 for macOS

[rickmark]

Currently the python bindings for universal2 in fact ship only the x64 version of libcapstone.dylib causing it to fail to load in arm64 python environments. This fix makes building of libcapstone.a and libcapstone.dylib universal2 (fat) by default with an option to disable if need be. This should fix the issue with python bindings as well as generally make capstone more pleasant for M1/2/3 users

[Rot127]

@kabeor Could you please trigger the workflows.

[rickmark]

Realized that for the bindings it was still relying on makefile build, so it wasn't taking the universal version. Used the same code path as windows to invoke cmake (is there value in keeping the makefile based version anymore?)

[Rot127]

is there value in keeping the makefile based version anymore?

Not really. It's considered deprecated and its easy to forget about it. The Python bindings need to be reworked anyways to get rid of the old stuff. But there is a lot to modernize and module updates + testing is currently higher on the list (at least for us Rizin folks).
But if you find the time, feel free to join the "renovate Capstone" struggle :)

[XVilka]

Note, once it's green, it would be good to cherry-pick to the 5.0.x series: #2081

[XVilka]

Building C extensions
    PWD: /Users/runner/work/capstone/capstone/build
    CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
    CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
    CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
    -- Configuring incomplete, errors occurred!
    No such file or directory
    CMake Error: Generator: execution of make failed. Make command was:
    error: [Errno 2] No such file or directory: 'libcapstone.5.dylib'
    ----------------------------------------
    ERROR: Failed building wheel for capstone

[rickmark]

I amended to resolve some of the issues (format strings are python3, and Ninja wasn't strictly needed as unix makefiles is fine), guess it needs a re-trigger?

[rickmark]

Building C extensions
    PWD: /Users/runner/work/capstone/capstone/build
    CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
    CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
    CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
    -- Configuring incomplete, errors occurred!
    No such file or directory
    CMake Error: Generator: execution of make failed. Make command was:
    error: [Errno 2] No such file or directory: 'libcapstone.5.dylib'
    ----------------------------------------
    ERROR: Failed building wheel for capstone

Options were adding Ninja to build host or switching cmake to unix makefiles, so using unix makefiles

[XVilka]

@kabeor please trigger workflows.

[XVilka]

Red CI looks like a network problem. It probably makes sense to restart.

[XVilka]

@kabeor please restart failed jobs one more time - I think it will be green.

[kabeor]

LGTM, but plz resolve the conflicts:)

[XVilka]

@kabeor I wonder if you can solve conflicts yourself, this is major problem for many macOS users, would be nice to get this merged sooner than later.

[rickmark]

Looks like PyPI is again failing for network reasons, merge of conflicts is complete

[XVilka]

@kabeor please merge this one

[kabeor]

Thank you!

[rickmark]

Any chance you're gonna release a pre / 5.X with this? I'd love to be able to use capstone on M1's soon

[Rot127]

Actually a early pre-release was planned. @kabeor Is there something missing for it?

[kabeor]

@Rot127 should be ready, will release after changing some version things

[rickmark]

Will this be a 5.0.2 or a 6.0pre?

[Rot127]

The pre-release will be 6.0pre. Because so much stuff changed, we want some kind of beta version.

[roblabla]

A couple months have passed. Is a pre-release still planned?

[Rot127]

Pre-release is still planned. Also the 5.0.2 release. Please be patient, I was recently added as maintainer to support, but it will take a little longer.