Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image-builder): use google keychain for Artifact Registry domains #553

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix(image-builder): use google keychain for Artifact Registry domains #553

merged 2 commits into from
Mar 19, 2024

Conversation

mbruner
Copy link
Member

@mbruner mbruner commented Mar 19, 2024

Description

To pull images from GCR image-builder checks if the image name contains "gcr.io". The new Artifact Registry uses different domain names, for example asia-docker.pkg.dev.

Modifications

  • Use google keychain for pkg.dev domains too.

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

NONE

@mbruner mbruner requested a review from ariefrahmansyah March 19, 2024 03:09
@mbruner mbruner added the bug Something isn't working label Mar 19, 2024
@mbruner mbruner requested a review from deadlycoconuts March 19, 2024 03:10
deadlycoconuts
deadlycoconuts approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thanks for the change too! But the linter's throwing some some minor error saying that the code isn't formatted :/

@mbruner mbruner mentioned this pull request Mar 19, 2024
Merged
@khorshuheng khorshuheng merged commit 308a0d6 into main Mar 19, 2024
32 checks passed
@khorshuheng khorshuheng deleted the add-support-of-artifact-registry branch March 19, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

@ariefrahmansyah ariefrahmansyah Awaiting requested review from ariefrahmansyah

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbruner @deadlycoconuts @khorshuheng