Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to caraml-dev/turing#387, this PR to fixes broken validation schemas caused by the upgrade of the
yup
package in PR #591 - these changes can largely be grouped into the following:The
Schema.when
function has been updated, such that when the builder object (one with the fieldsis
,then
, and sometimesotherwise
defined) is passed as an argument, thethen
field accepts ONLY functions of the following signature(schema: Schema) => Schema
instead ofSchema
previously.Existing schemas that do not follow this convention have been updated and turned into arrow functions.
Example:
When using the same
Schema.when
function but passing a function directly as an argument instead of the builder object, the signature of the expected function has also been updated from(value, schema)=> Schema): Schema
to(values: any[], schema) => Schema): Schema
.Existing schemas that do not follow this convention now have been updated to reflect the new expected array:
Example:
Unrelated Update
This PR also bumps up the version of the
caraml-dev/ui-lib
library to the latest version.Modifications
caraml-dev/ui-lib
libraryTests
Checklist
Release Notes