-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make update project settings endpoint call URL with template payload + add a labels blacklist #99
Conversation
ca5a104
to
944a17c
Compare
b4e08f3
to
dd24069
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 57.39% 57.14% -0.25%
==========================================
Files 47 47
Lines 2354 2443 +89
==========================================
+ Hits 1351 1396 +45
- Misses 827 851 +24
- Partials 176 196 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d417ef2
to
88ac43d
Compare
ui/packages/app/src/project_setting/project_info/ProjectInfoForm.js
Outdated
Show resolved
Hide resolved
27190ce
to
e25db82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of additional comments; please test your changes too to make sure they work 🙏🏼
e4b4a8d
to
b7927ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of the changes now look good. I left some other comments, some are not really urgent/important, but the most important thing is to ensure the UI's working as expected. I'll approve this PR first but please take a look at the UI at least first :) 🚀
…l, update unit tests
ce06c8a
to
86c729b
Compare
This PR introduces three new configs (to be read from the yaml file) to the MLP API server. The configs that are being added are:
Additionally, a labels blacklist config will be added that hides/prevents the labels contained within to not be modifiable