Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make update project settings endpoint call URL with template payload + add a labels blacklist #99

Merged
merged 27 commits into from
Jun 20, 2024

Conversation

jonathanv28
Copy link
Collaborator

@jonathanv28 jonathanv28 commented May 20, 2024

This PR introduces three new configs (to be read from the yaml file) to the MLP API server. The configs that are being added are:

  1. Endpoint to be called when the update projects settings endpoint is called
  2. Request payload JSON template to be sent to the specified endpoint
  3. Response URL template to be sent back to the user

Additionally, a labels blacklist config will be added that hides/prevents the labels contained within to not be modifiable

@jonathanv28 jonathanv28 force-pushed the call-update-url branch 2 times, most recently from b4e08f3 to dd24069 Compare May 30, 2024 16:05
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.14%. Comparing base (688c2fc) to head (86c729b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   57.39%   57.14%   -0.25%     
==========================================
  Files          47       47              
  Lines        2354     2443      +89     
==========================================
+ Hits         1351     1396      +45     
- Misses        827      851      +24     
- Partials      176      196      +20     
Flag Coverage Δ
api-test 57.14% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathanv28 jonathanv28 force-pushed the call-update-url branch 2 times, most recently from d417ef2 to 88ac43d Compare June 4, 2024 10:41
@jonathanv28 jonathanv28 marked this pull request as ready for review June 4, 2024 10:49
api/api/router.go Outdated Show resolved Hide resolved
api/config/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of additional comments; please test your changes too to make sure they work 🙏🏼

api/api/projects_api.go Outdated Show resolved Hide resolved
api/service/projects_service.go Outdated Show resolved Hide resolved
api/api/router.go Outdated Show resolved Hide resolved
api/config/config.go Outdated Show resolved Hide resolved
api/config/config.go Outdated Show resolved Hide resolved
api/service/projects_service.go Outdated Show resolved Hide resolved
api/service/projects_service.go Outdated Show resolved Hide resolved
api/service/projects_service.go Show resolved Hide resolved
ui/packages/app/src/project_setting/form/Labels.js Outdated Show resolved Hide resolved
@jonathanv28 jonathanv28 force-pushed the call-update-url branch 2 times, most recently from e4b4a8d to b7927ca Compare June 13, 2024 13:54
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the changes now look good. I left some other comments, some are not really urgent/important, but the most important thing is to ensure the UI's working as expected. I'll approve this PR first but please take a look at the UI at least first :) 🚀

@jonathanv28 jonathanv28 merged commit 8a02334 into caraml-dev:main Jun 20, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants