Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Fix incorrect tag name used to check for the existence of built docker images #374

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Apr 5, 2024

Context

Following up on the changes to edit the naming convention of docker images built by the Turing API server in PR #368, this PR introduces a tiny fix to a part of the image building process that checks for the existence of a docker image with the same tag.

Previously the tag was left as the ensembler id, which is incorrectly, given the changes proposed in PR #368. This PR corrects the image tag used for the check mentioned above to the ensembler run id. Here's a recap of how the changes should look like:

Before

{dockerRegistry}/{projectName}-{ensemblerName}-{runID}-service:{ensemblerID}

or

{dockerRegistry}/{projectName}-{ensemblerName}-{runID}-job:{ensemblerID}

After

{dockerRegistry}/{projectName}/ensembler-services/{ensemblerName}:{runID}

or

{dockerRegistry}/{projectName}/ensembler-jobs/{ensemblerName}:{runID}

@deadlycoconuts deadlycoconuts added the type: bug Something isn't working label Apr 5, 2024
@deadlycoconuts deadlycoconuts self-assigned this Apr 5, 2024
Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@deadlycoconuts deadlycoconuts merged commit 2aa0d13 into caraml-dev:main Apr 5, 2024
11 checks passed
@deadlycoconuts deadlycoconuts deleted the fix_docker_registry_image_exists_check branch May 7, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants