-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): Upgrade UI dependencies #384
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 68.09% 68.07% -0.02%
==========================================
Files 149 149
Lines 11809 11809
==========================================
- Hits 8041 8039 -2
- Misses 3030 3032 +2
Partials 738 738
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
55cb301
to
af1f1a8
Compare
7fbe71f
to
a7e507d
Compare
e2829e9
to
7a421b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, not much i can input here. Looks fine to me overall, just the concern that roadblocks are not clearly doc and will be lost over time
Thanks a lot for the quick review! And thanks @ariefrahmansyah for this PR too (I had to refer to the stuff you did for MLP and Merlin for some changes you had already done; sorry for all the crazy email notifications from all the git pushes 👀)! I've added the UI comments here, just like in XP: https://github.com/caraml-dev/turing/pull/384/files#diff-193b27d62e4fbda3d563009fed5ec6761a05f73558d94b39fab63ae948c679eaR5 |
Context
Similar to what had been done in MLP caraml-dev/mlp#100 and in Merlin caraml-dev/merlin#591, this PR updates certain UI dependencies in Turing, most notably:
package.json
file to pin the engine to >=20.13.1)EuiAccordion
-related components; this is likely due a massive rework of the component in this PR [EuiAccordion] Split up rendering into sub-components & other cleanups elastic/eui#7161 but I've no idea why this change didn't affect the accordions in MerlinOther minor changes have also been made to the GitHub CICD files (more details are covered below and in the comments left on the diff itself).
Main Changes
GitHub Actions Updates
actions/upload-artifact
- from v2 to v4 since the former has already been deprecated since the 30th of June this yearactions/download-artifact
- from v2 to v4 since the former has already been deprecated since the 30th of June this year (the versions of this action andupload-artifact
need to be compatible to work)actions/checkout
- from v3 to v4 since it's similarly done in the MLP repoactions/setup-go
- from v4 to v5 since it's similarly done in the MLP repo (also provides caching)actions/setup-python
- from v2 to v5 to keep it updated to the latest version (also provides caching)docker/login-action
- from v1 to v3 just to keep it updated to the latest versionjupyterhub/action-k8s-await-workloads
- from v1 to v3 just to keep it updated to the latest version