Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Remove regex check for autoscaling target in autogenerated files #385

Conversation

deadlycoconuts
Copy link
Contributor

Context

Previously in #380, the autoscaling target was refactored to allow strings with decimal places. However, this wasn't exposed (unintentionally) because the autogenerated Go/Python files from the OpenAPI specs weren't updated. This PR removes the regex check (which had previously only allowed integers as target values) in the OpenAPI specs and updates all the necessary Go/Python files as a result of that change.

@deadlycoconuts deadlycoconuts requested a review from leonlnj July 16, 2024 04:28
@deadlycoconuts deadlycoconuts self-assigned this Jul 16, 2024
@deadlycoconuts deadlycoconuts added the type: bug Something isn't working label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (4f1cbd2) to head (3365235).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   62.27%   68.07%   +5.79%     
==========================================
  Files         124      149      +25     
  Lines        9774    11809    +2035     
==========================================
+ Hits         6087     8039    +1952     
- Misses       2949     3032      +83     
  Partials      738      738              
Flag Coverage Δ
api-test 62.27% <ø> (ø)
sdk-test-3.10 95.92% <ø> (?)
sdk-test-3.8 95.92% <ø> (?)
sdk-test-3.9 95.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deadlycoconuts deadlycoconuts merged commit bb73a1f into caraml-dev:main Jul 16, 2024
29 checks passed
@deadlycoconuts deadlycoconuts deleted the remove_api_spec_regex_autoscaling_check branch July 16, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants