Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] v12 support #736

Closed
5 tasks done
tay1orjones opened this issue Nov 20, 2019 · 4 comments · Fixed by #1253
Closed
5 tasks done

[node] v12 support #736

tay1orjones opened this issue Nov 20, 2019 · 4 comments · Fixed by #1253
Assignees
Labels
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Nov 20, 2019

Summary

We have not tested if the codebase builds properly with Node v12. This needs to be validated.

  • update .nvmrc to 12
  • add engines field to package.json as a best practice, specify 12.x
  • update any required dependencies to ensure the build and Travis CI aren't interrupted
  • update any documentation that specifies the previous 10.15.3 version from [node] specify v10 and document #735
  • ensure the runtimeVersion is updated in ./.vscode/launch.json

Internal issue #62

@tay1orjones tay1orjones added the type: enhancement 💡 New feature or request label Nov 20, 2019
@tay1orjones
Copy link
Member Author

tay1orjones commented Nov 20, 2019

Node release schedule for reference

Major Node.js versions enter Current release status for six months, which gives library authors time to add support for them. After six months, odd-numbered releases (9, 11, etc.) become unsupported, and even-numbered releases (10, 12, etc.) move to Active LTS status and are ready for general use. LTS release status is "long-term support", which typically guarantees that critical bugs will be fixed for a total of 30 months. Production applications should only use Active LTS or Maintenance LTS releases.

image

@davidicus davidicus added this to the Sprint 36 milestone Nov 25, 2019
@davidicus davidicus removed this from the Sprint 36 milestone Dec 4, 2019
@tay1orjones
Copy link
Member Author

This will bring us in line with Carbon, they updated in carbon-design-system/carbon#5391

@tay1orjones tay1orjones mentioned this issue Apr 30, 2020
6 tasks
@tay1orjones
Copy link
Member Author

I believe this will fix the node warning we see in the console when running the test suite

(node:41998) ExperimentalWarning: The fs.promises API is experimental

@tay1orjones
Copy link
Member Author

🎉 This issue has been resolved in version 2.82.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tay1orjones tay1orjones self-assigned this Jun 3, 2020
@tay1orjones tay1orjones added this to the Sprint 49 milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants