Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker): specify partial type for flatpickrOptions #2666

Conversation

flisijn
Copy link
Contributor

@flisijn flisijn commented Jul 28, 2023

Closes #2665

Add the type for the flatpickrOptions input in the Date picker component

@flisijn flisijn requested a review from a team as a code owner July 28, 2023 10:25
@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 8fbb3ae
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/6605cfcef1b0c600081260b0
😎 Deploy Preview https://deploy-preview-2666--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

Signed-off-by: Hubert Flisijn <h.flisijn@avisi.nl>
@flisijn flisijn force-pushed the datepicker-flatpickroptions-type-2665 branch from 6e4bc97 to 47fea8a Compare July 28, 2023 10:41
@flisijn
Copy link
Contributor Author

flisijn commented Jul 28, 2023

I have read the DCO document and I hereby sign the DCO.

@flisijn
Copy link
Contributor Author

flisijn commented Jul 28, 2023

recheck

src/datepicker/datepicker.component.ts Outdated Show resolved Hide resolved
src/datepicker/datepicker.component.ts Outdated Show resolved Hide resolved
src/datepicker/datepicker.component.ts Outdated Show resolved Hide resolved
@Akshat55 Akshat55 changed the title fix(date-picker) Specify type for flatpickrOptions fix(date-picker): specify partial type for flatpickrOptions Mar 28, 2024
@Akshat55 Akshat55 enabled auto-merge (squash) March 28, 2024 21:53
@Akshat55 Akshat55 disabled auto-merge March 28, 2024 21:53
@Akshat55 Akshat55 merged commit e8a195b into carbon-design-system:master Mar 28, 2024
13 checks passed
Copy link

🎉 This PR is included in version 5.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Date picker] flatpickrOptions input does not have the correct type
2 participants