Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fluid state for text input and password #3011

Merged
merged 9 commits into from
Nov 6, 2024
Merged

feat: add fluid state for text input and password #3011

merged 9 commits into from
Nov 6, 2024

Conversation

eduardmarcinco
Copy link
Contributor

Closes #2892

Notes:

  • @carbon/styles version update is required. Fixes for password input were released recently.
  • a way of displaying skeleton was updated as now it needs to handle standard skeleton and fluid skeleton depending on the input property

@eduardmarcinco eduardmarcinco requested a review from a team as a code owner September 25, 2024 09:22
@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 2bf9665
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/672ba1ff368d4100087f4510
😎 Deploy Preview https://deploy-preview-3011--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brampeirs
Copy link
Contributor

Q: does storybook still compile for you on version 1.65 for the styles? For me I get a webpack error. When changing version to 1.67 everything works again.

@eduardmarcinco
Copy link
Contributor Author

@brampeirs i have no issues with @carbon/styles v1.65.0
I tried just now on this branch.
image
image

@Akshat55
chore: update carbon styles package
ac1d505
@Akshat55
chore: lint fix
472f8ce 
Signed-off-by: Akshat Patel <akshat@live.ca>
@Akshat55
Merge branch 'fluid/text-password' of https://github.com/eduardmarcin…
63458e3 
…co/carbon-components-angular into fluid/text-password
@Akshat55
feat: wrap overflow menu button in tooltip
64d291b 
Signed-off-by: Akshat Patel <akshat@live.ca>
@Akshat55
chore: simplify conditions
fad43ab 
Signed-off-by: Akshat Patel <akshat@live.ca>
@Akshat55
chore: use full word for getter
2bf9665 
Signed-off-by: Akshat Patel <akshat@live.ca>
@Akshat55 Akshat55 changed the title feat: fluid state for text input and password feat: add fluid state for text input and password Nov 6, 2024
@Akshat55 Akshat55 merged commit fa4f99d into carbon-design-system:master Nov 6, 2024
14 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 5.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akshat55 Akshat55 Akshat55 approved these changes

Assignees
No one assigned
Labels
released on @latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fluid state for Text Input/Password
3 participants
@eduardmarcinco @brampeirs @Akshat55