Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying a size for the pagination nav component #3034

Merged

Conversation

brampeirs
Copy link
Contributor

@brampeirs brampeirs commented Oct 23, 2024

Allow specifying a size for the pagination nav component as is documented in spec.

pagination

carbon spec

Changelog

New

  • New size property for pagination nav component sm, md, lg defaults to lg as this is default now.

Changed

  • had to bump carbon/styles version to 1.67
  • updated storybook
pagination.mov

@brampeirs brampeirs requested a review from a team as a code owner October 23, 2024 14:02
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 7399dec
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/67212aa87830030008729712
😎 Deploy Preview https://deploy-preview-3034--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zvonimirfras zvonimirfras merged commit 2aac746 into carbon-design-system:master Oct 29, 2024
14 checks passed
Copy link

🎉 This PR is included in version 5.48.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants