This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
refactor(Slider): replace Carbon TextInput #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit c23b2c6 https://deploy-preview-2085--carbon-components-react.netlify.com |
shixiedesign
approved these changes
Mar 22, 2019
shixiedesign
added
status: one more review 👀
and removed
status: ready for review 👀
labels
asudoh
pushed a commit
that referenced
this pull request
Mar 27, 2019
* feat(DataTable): Add sorting params to header onClick callback * chore(build): update size threshold * fix(progressIndicatorSkeleton): Update html to fix styling (#2084) * fix: update skeleton svg for progress indicator * chore: update html * refactor(Slider): replace Carbon TextInput (#2085) * feat(DataTable): Add sorting params to header onClick callback
|
🎉 This PR is included in version 6.112.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IBM/carbon-components-react#2082
<TextInput>(and several other form components) include the<FormItem>wrapper out of the box. This PR replaces<TextInput>in the<Slider>component with native text inputs so that<Form>styles are not applied.Related: https://github.com/IBM/carbon-components-react/issues/1681