Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card Static] Clicking next the link, CTA link is getting focus #6229

Closed
Praveen-sr opened this issue Jun 2, 2021 · 3 comments · Fixed by #7463
Closed

[Card Static] Clicking next the link, CTA link is getting focus #6229

Praveen-sr opened this issue Jun 2, 2021 · 3 comments · Fixed by #7463
Assignees
@andy-blum
Labels
bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed
Milestone
Sprint 21-21

Comments

@Praveen-sr
Copy link

Praveen-sr commented Jun 2, 2021 •
edited by proeung
Loading

Engineering info:

Detailed description

Issue:
Clicking next the link, CTA link is getting focus

Additional information

image.png
@Praveen-sr Praveen-sr added bug Something isn't working severity 4 Affects minor functionality, no workaround needed labels Jun 2, 2021
This was referenced Jun 3, 2021
Closed
Merged
@jeffchew jeffchew added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package labels Jun 18, 2021
@jeffchew jeffchew modified the milestones: Sprint 21-18, Sprint 21-20 Jun 18, 2021
@jeffchew jeffchew modified the milestones: Sprint 21-16, Sprint 21-17 Jun 29, 2021
@jeffchew jeffchew modified the milestones: Sprint 21-17, Sprint 21-19 Jul 13, 2021
@jeffchew jeffchew removed this from the Sprint 21-19 milestone Aug 20, 2021
@jeffchew jeffchew added this to the Sprint 21-22 milestone Aug 20, 2021
@jeffchew jeffchew changed the title Web component: Card Static - Clicking next the link, CTA link is getting focus [Card Static] Clicking next the link, CTA link is getting focus Aug 24, 2021
@proeung proeung added the owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants label Oct 13, 2021
@proeung
Copy link
Contributor

proeung commented Oct 13, 2021 •
edited
Loading

@Praveen-sr I just checked PROD and Canary Storybook preview and I'm not able to replicate the focus issue that you're seeing. Can you take a look again?

@andy-blum
Copy link
Member

@proeung I'm still getting a focus outline on the CTA link when clicking to the right of it. I'll see if I cant fix it as part of #6255

@proeung
Copy link
Contributor

proeung commented Oct 13, 2021

@andy-blum Yeah, on testing the static card variant again, I do see that the focus outline is showing when you click on the card. If you can wrap a solution for this issue in #6255 that would be great. Thanks!

@proeung proeung modified the milestones: Sprint 21-22, Sprint 21-21 Oct 13, 2021
This was referenced Oct 15, 2021
Closed
Merged
@kodiakhq kodiakhq bot closed this as completed in #7463 Oct 21, 2021
kodiakhq bot pushed a commit that referenced this issue Oct 21, 2021
@andy-blum
fix(card): Update card styling & layout (#7463)
a420912 
### Related Ticket(s)

Fixes: #6229 #6255 

### Description

- Updates styles of card component to match specs
- Modernizes spacing techniques of card copy wrapper
- Reduces width of CTA link host element to prevent focus-on-adjacent-click

### Changelog

**Changed**

- Updated card styles
- Updated tag-group styles
- Fixed bug where clicking next to a card link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-blum andy-blum

Labels
bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed
Projects
None yet
Milestone
Sprint 21-21
10 participants
@jeffchew @proeung @shixiedesign @ariellalgilmore @ljcarot @andy-blum @DragosRistici @RobertaJHahn @andysherman2121 @Praveen-sr