Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(percy): skip notice-choice component #11844

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore(percy): skip notice-choice component #11844

merged 1 commit into from
Jun 4, 2024

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Jun 4, 2024

Description

Remove notice-choice from Percy snapshots.

Changelog

Changed

  • skip notice-choice in Percy snapshot tests

@kennylam kennylam added the package: web components Work necessary for the IBM.com Library web components package label Jun 4, 2024
@kennylam kennylam requested a review from a team as a code owner June 4, 2024 17:09
@kennylam kennylam requested review from emyarod and ariellalgilmore and removed request for a team June 4, 2024 17:09
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11844/index.html

Built with commit: 0518d0ef2395dca325f2fd1a75879cd791d6b58e

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11844/index.html

Built with commit: 0518d0ef2395dca325f2fd1a75879cd791d6b58e

emyarod
emyarod approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11844/index.html

Built with commit: 0518d0ef2395dca325f2fd1a75879cd791d6b58e

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11844/index.html

Built with commit: 0518d0ef2395dca325f2fd1a75879cd791d6b58e

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jun 4, 2024
@kodiakhq kodiakhq bot merged commit f2470de into carbon-design-system:main Jun 4, 2024
17 of 20 checks passed
@kennylam kennylam deleted the chore/notice-choice-skip-percy branch June 4, 2024 18:34
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@emyarod emyarod emyarod approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennylam @ibmdotcom-bot @emyarod @annawen1