Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-element): ensure all cwc components use carbonElement #11937

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix(custom-element): ensure all cwc components use carbonElement #11937

merged 1 commit into from
Jul 22, 2024

Conversation

annawen1
Copy link
Member

Related Ticket(s)

Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}}

Description

Ensure all CWC are using the carbonElement decorator to prevent clashing when user is trying to import the same component from different locations

Changelog

Changed

  • ensure all CWC are importing and using the carbonElement decorator

@annawen1 annawen1 requested a review from a team as a code owner July 22, 2024 13:37
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11937/index.html

Built with commit: 73be968e07873f50d852a5fcbfa5d99d0e7e5492

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11937/index.html

Built with commit: 73be968e07873f50d852a5fcbfa5d99d0e7e5492

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11937/index.html

Built with commit: 73be968e07873f50d852a5fcbfa5d99d0e7e5492

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11937/index.html

Built with commit: 73be968e07873f50d852a5fcbfa5d99d0e7e5492

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Jul 22, 2024
@annawen1 annawen1 merged commit f727bae into carbon-design-system:release/v2.11.0 Jul 22, 2024
13 of 21 checks passed
@annawen1 annawen1 deleted the fix/custom-element-decorator branch July 22, 2024 22:46
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.11.0.

annawen1 added a commit to annawen1/carbon-for-ibm-dotcom that referenced this pull request Jul 24, 2024
@annawen1
fix(custom-element): ensure all cwc components use carbonElement (car…
b7bd8d6 
…bon-design-system#11937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annawen1 @ibmdotcom-bot @ariellalgilmore