Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carbon-web-components): introduce CDN artifacts #6867

Closed

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

Refs carbon-design-system/carbon-web-components#661

Description

This introduces CDN artifacts for carbon-web-components. This build
would not only be easier from a deployment standpoint to introduce here,
but also it would be able to safely handle any duplicate declarations
of custom elements whereas that would be difficult to handle if Carbon
for IBM.com and carbon-web-components was built separately.

Once merged, the following will be available to use via CDN:

NOTE: This will need to have carbon-design-system/carbon-web-components#681 merged and released first before this can be merged in.

Changelog

New

  • CDN artifacts for carbon-web-components added to build:components script
  • Added codesandbox example with carbon-web-components

This introduces CDN artifacts for `carbon-web-components`. This build
would not only be easier from a deployment standpoint to introduce here,
 but also it would be able to safely handle any duplicate declarations
 of custom elements whereas that would be difficult to handle if Carbon
 for IBM.com and carbon-web-components was built separately.
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 11, 2021

Deploy preview created for package Web Components - Codesandbox Examples:
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/6867/

Built with commit: b986049aa7747fc14e44279b5cd46cdd0d46f4a5

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@jeffchew
Copy link
Member Author

Closing this. Discovered that there is a babel config in place that prevents carbon-web-components custom elements from getting defined in our repo, so it might actually make sense to have it have its own deployment scripts.

@jeffchew jeffchew closed this Aug 12, 2021
@jeffchew jeffchew deleted the feat/web-components-cdn branch August 24, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants