Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content-block-horizontal): update bottom section spacing #8187

Merged
merged 3 commits into from
Feb 4, 2022
Merged

fix(content-block-horizontal): update bottom section spacing #8187

merged 3 commits into from
Feb 4, 2022

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 1, 2022

Related Ticket(s)

#7745

Description

This PR updates the content-block-horizontal component so that the dds-hr spacing from the content matches the spec (https://ibm.ent.box.com/file/802632469676).

Changelog

Changed

  • dds-hr spacing in content-block-horizontal

@emyarod emyarod added Needs design approval PRs on feature requests and new components have to get design approval before merge. 👀 eyes needed labels Feb 1, 2022
@emyarod emyarod requested a review from a team as a code owner February 1, 2022 21:12
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8187/index.html

Built with commit: e314075c163d2c8a650d25dc5d0376100801703b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8187/index.html

Built with commit: e314075c163d2c8a650d25dc5d0376100801703b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8187/index.html

Built with commit: e314075c163d2c8a650d25dc5d0376100801703b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8187/index.html

Built with commit: e314075c163d2c8a650d25dc5d0376100801703b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8187/index.html

Built with commit: e314075c163d2c8a650d25dc5d0376100801703b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8187/index.html

Built with commit: e314075c163d2c8a650d25dc5d0376100801703b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8187/index.html

Built with commit: e314075c163d2c8a650d25dc5d0376100801703b

oliviaflory
oliviaflory approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @emyarod !

@oliviaflory oliviaflory removed 👀 eyes needed Needs design approval PRs on feature requests and new components have to get design approval before merge. labels Feb 3, 2022
@emyarod emyarod force-pushed the 7745-fix/content-block-horizontal-bottom-spacing branch from e97dd51 to a6d6a28 Compare February 3, 2022 20:38
@oliviaflory oliviaflory mentioned this pull request Feb 4, 2022
Closed
ariellalgilmore
ariellalgilmore approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! the only thing is maybe we want to use $spacing instead

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 4, 2022
@emyarod
Copy link
Member Author

emyarod commented Feb 4, 2022

@ariellalgilmore it looks like the rest of that stylesheet uses layout tokens, should we change them all?

@kodiakhq kodiakhq bot merged commit 3a02f57 into carbon-design-system:main Feb 4, 2022
@emyarod emyarod deleted the 7745-fix/content-block-horizontal-bottom-spacing branch February 7, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviaflory oliviaflory oliviaflory approved these changes

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emyarod @ibmdotcom-bot @ariellalgilmore @oliviaflory @jeffchew