Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(filter-panel): add view all button for filter groups" #8252

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Revert "feat(filter-panel): add view all button for filter groups" #8252

merged 2 commits into from
Feb 11, 2022

Conversation

IgnacioBecerra
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra commented Feb 11, 2022 •
edited
Loading

This reverts commit 6a55992.

Related Ticket(s)

Reverting #8188

Description

Reverting for the time being.

Changelog

Removed

  • the changes done in the linked PR

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 11, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8252/index.html

Built with commit: 0a30918ed7bf7dff5f0968ced28caa7912933f52

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 11, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8252/index.html

Built with commit: 0a30918ed7bf7dff5f0968ced28caa7912933f52

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 11, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8252/index.html

Built with commit: 0a30918ed7bf7dff5f0968ced28caa7912933f52

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 11, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8252/index.html

Built with commit: 0a30918ed7bf7dff5f0968ced28caa7912933f52

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 11, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8252/index.html

Built with commit: 0a30918ed7bf7dff5f0968ced28caa7912933f52

@IgnacioBecerra IgnacioBecerra marked this pull request as ready for review February 11, 2022 21:01
@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner February 11, 2022 21:01
@IgnacioBecerra IgnacioBecerra changed the title Revert "feat(filter-panel): add view all button for filter groups (#8… Revert "feat(filter-panel): add view all button for filter groups" Feb 11, 2022
emyarod
emyarod approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Feb 11, 2022
Closed
@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 11, 2022
@kodiakhq kodiakhq bot merged commit 97aa93b into carbon-design-system:main Feb 11, 2022
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8252/index.html

Built with commit: 0a30918ed7bf7dff5f0968ced28caa7912933f52

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8252/index.html

Built with commit: 0a30918ed7bf7dff5f0968ced28caa7912933f52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IgnacioBecerra @ibmdotcom-bot @emyarod @jeffchew