Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

fix(ui-shell header): improve header accessibility #711

Merged
merged 2 commits into from
Oct 18, 2021
Merged

fix(ui-shell header): improve header accessibility #711

merged 2 commits into from
Oct 18, 2021

Conversation

andy-blum
Copy link
Member

Related Ticket(s)

Fixes #708

Description

Removes all menu-based roles from the ui-shell header components & their respective styles

Changelog

Changed

  • Improved accessibility in BXHeader components

@andy-blum andy-blum requested a review from a team as a code owner October 11, 2021 14:29
@andy-blum andy-blum requested review from BrunnoM7, annawen1 and skuruvil and removed request for a team October 11, 2021 14:29
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/711/index.html

Built with commit: e97e76d0bb70bb8e77366a67f3c7d17dfde26162

@proeung proeung mentioned this pull request Oct 11, 2021
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/711/index.html

Built with commit: e97e76d0bb70bb8e77366a67f3c7d17dfde26162

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/711/index.html

Built with commit: e97e76d0bb70bb8e77366a67f3c7d17dfde26162

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/711/index.html

Built with commit: e97e76d0bb70bb8e77366a67f3c7d17dfde26162

kennylam
kennylam approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @andy-blum!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Oct 18, 2021
@kodiakhq kodiakhq bot merged commit 00d912c into carbon-design-system:master Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennylam kennylam kennylam approved these changes

@BrunnoM7 BrunnoM7 Awaiting requested review from BrunnoM7 BrunnoM7 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@skuruvil skuruvil Awaiting requested review from skuruvil skuruvil was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
hacktoberfest-accepted package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui shell] Accessibility issues in header
3 participants
@andy-blum @ibmdotcom-bot @kennylam