This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
fix(slider): fix slider usability on touch devices #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Fixes #830
Description
This PR makes several usability improvements to the slider component:
touch-action: none;
to the slider thumb control whilethis._dragging == true
.handleMousedownTrack
tohandleClick
and moves listener from track element to slider element to increase the clickable area with a fine pointing device such as a stylus or mouse.pointerleave
andpointerup
listener to the slider root to cancel the dragging action.Changelog
Changed