Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

fix(drop-container): clear input value on change #924

Merged
merged 2 commits into from
Feb 3, 2022
Merged

fix(drop-container): clear input value on change #924

merged 2 commits into from
Feb 3, 2022

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jan 12, 2022

Related Ticket(s)

#904

Description

This PR clears the file uploader input value so that the same file can be reuploaded after being cleared from the previous upload attempt

To test this, upload a file, remove it, and then reupload the same file and confirm that it is added to the file list correctly

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/924/index.html

Built with commit: 35aa8c6aa38145a77e7707fdb8f903318d3018e0

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/924/index.html

Built with commit: 35aa8c6aa38145a77e7707fdb8f903318d3018e0

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/924/index.html

Built with commit: 35aa8c6aa38145a77e7707fdb8f903318d3018e0

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/924/index.html

Built with commit: 35aa8c6aa38145a77e7707fdb8f903318d3018e0

@emyarod emyarod force-pushed the 904-fix/file-uploader-reselect-item branch from ae00a25 to 6dc0406 Compare January 13, 2022 14:58
@emyarod emyarod marked this pull request as ready for review January 13, 2022 14:58
@emyarod emyarod requested a review from a team as a code owner January 13, 2022 14:58
@emyarod emyarod requested review from oliviaflory and annawen1 and removed request for a team January 13, 2022 14:58
IgnacioBecerra
IgnacioBecerra approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that files can be reuploaded without error. LGTM, thanks @emyarod!

jeffchew
jeffchew approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 3, 2022
@kodiakhq kodiakhq bot merged commit fe78124 into carbon-design-system:main Feb 3, 2022
@emyarod emyarod deleted the 904-fix/file-uploader-reselect-item branch February 4, 2022 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@jeffchew jeffchew jeffchew approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory oliviaflory is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emyarod @ibmdotcom-bot @jeffchew @IgnacioBecerra