Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: Update live demo #2660

Closed
Tracked by #8487
kingtraceyj opened this issue Dec 6, 2021 · 3 comments · Fixed by #3597
Closed
Tracked by #8487

Tabs: Update live demo #2660

kingtraceyj opened this issue Dec 6, 2021 · 3 comments · Fixed by #3597

Comments

@kingtraceyj
Copy link
Member

Live demo needs to be updated to reflect v11 changes

@sstrubberg sstrubberg changed the title [Tabs v11] Update live demo Tabs: Update live demo May 2, 2023
@sstrubberg sstrubberg moved this to ⏱ Backlog in Design System May 2, 2023
@sstrubberg sstrubberg added this to the 2023 Q2 milestone May 2, 2023
@kingtraceyj
Copy link
Member Author

Hoping we can structure the live demo a little closer to how we structured our docs:

image

Visuals:
image

Showing icon with size selector for line tabs:
image

@kingtraceyj
Copy link
Member Author

the original design above is the ideal configuration that follows our current doc structure. it differs slightly from our storybook right now.

after chatting with @andreancardona, in the short term, we will stick with the current storybook structure and update the live demo component according to priority of the Storybook audit:
https://airtable.com/appOqWyfQBLznbeE7/tbldm9oxL5kMaRFh7/viw2hSBv9swEUJTNt?blocks=hide

Demo with current storybook structure and temporary live demo design:
image

@tw15egan
Copy link
Collaborator

Just wanted to point out, the knobs on the right directly map to what props are used in the react components themselves, with the exact naming a developer would use. The above idea of a kind with text & icons isn't a prop but rather a pattern a user would construct, and could lead to some confusion.

@tay1orjones tay1orjones moved this from 🏗 In Progress to 🚦 In Review in Design System Jun 15, 2023
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants