Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Updates and enhancements #8487

Closed
14 tasks done
Tracked by #9973
kingtraceyj opened this issue Apr 22, 2021 · 23 comments
Closed
14 tasks done
Tracked by #9973

Tab Updates and enhancements #8487

kingtraceyj opened this issue Apr 22, 2021 · 23 comments
Labels
component: tabs epic Special label used by ZenHub for epic functionality package: react carbon-components-react planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖 type: enhancement 💡
Milestone

Comments

@kingtraceyj
Copy link
Member

kingtraceyj commented Apr 22, 2021

We are updating the usage docs to account for more use cases.

Improvement on existing tabs

  1. Name change (Default tabs we are now calling line tabs and container tabs we are now calling contained tabs)
  2. Updating default functionality (We are recommending line tabs use auto-spacing and contained tabs can use either auto-spacing or grid)

Adding modifiers

Line tabs

  • Icon-only
  • Label with icon

Contained tabs

  • Icon-only
  • Label with icon
  • Label with secondary label
  • Label with secondary label and icon

Adding in motion

  • TBD - new issue will come for this

See below more more details.

Pieces delivered in v11:

Tasks

  1. component: tabs proposal: accepted role: dev 🤖 type: enhancement 💡
    francinelucca
  2. 4 of 4
    component: tabs package: @carbon/react proposal: accepted role: dev 🤖 type: enhancement 💡 version: 11
    francinelucca
  3. 3 of 3
    component: tabs package: @carbon/react proposal: accepted role: dev 🤖 type: enhancement 💡 version: 11
    francinelucca
  4. 0 of 2
    component: tabs role: dev 🤖
    francinelucca
  5. component: tabs package: @carbon/react proposal: accepted role: dev 🤖 type: enhancement 💡 version: 11
    francinelucca
  6. 3 of 3
    component: tabs package: @carbon/react proposal: accepted role: dev 🤖 status: blocked 🙅‍♀️ type: enhancement 💡 version: 11
    alisonjoseph
  7. component: tabs role: design ✏️ type: enhancement 💡
    laurenmrice
  8. component: tabs package: @carbon/react role: dev 🤖 type: enhancement 💡
    francinelucca guidari
  9. component: tabs role: dev 🤖
    kingtraceyj
  10. area: component-demo component: tabs role: dev 🤖 type: bug 🐛
    andreancardona
  11. component: tabs role: design ✏️ type: enhancement 💡
    kingtraceyj
  12. kit: figma role: design ✏️ type: enhancement 💡
    kingtraceyj
  13. component: tabs role: design ✏️ type: docs 📖 type: enhancement 💡
    kingtraceyj
@kingtraceyj
Copy link
Member Author

Name update

In docs we will now refer to tabs as line tabs and container tabs as contained tabs. We're getting rid of the work default since we use it differently through our components.

Default functionality

We now recommend using auto-spacing for line tabs. Contained tabs can use both auto-spacing or the grid.

Line:
image

Contained:
image

New modifiers

Line tabs

Icon-only
Screen Shot 2021-04-22 at 2 19 59 PM

With icon
image

Contained tabs

Contained with icon (auto-spaced and grid)
image

Contained with secondary label + icon
image

Contained - icon-only
image

@kingtraceyj
Copy link
Member Author

one small update -- we will have 2 sizes for the icon-only line tabs. a medium/default one (40px) and a large one (48px)
image

@kingtraceyj
Copy link
Member Author

here are better, hopefully more helpful specs:
Tabs - white theme
Tabs - Specs - White theme

@tay1orjones tay1orjones changed the title Tab Updates and enhancements ☂️ Tab Updates and enhancements Oct 26, 2021
@tay1orjones
Copy link
Member

Contained with secondary label + icon
image

@carbon-design-system/design @kingtraceyj Something that came up when @abbeyhrt and I were beginning to look at implementing this today was a question around alignment and these secondary labels.

If only one tab is provided a secondary label, should the others have an empty secondary label taking up the same vertical space so that the text/icons remains aligned?

tabs

Or should the ones without secondary labels revert to the default middle alignment?

tabs

@tay1orjones tay1orjones changed the title ☂️ Tab Updates and enhancements [Umbrella]: Tab Updates and enhancements Nov 1, 2021
@tay1orjones tay1orjones changed the title [Umbrella]: Tab Updates and enhancements [Umbrella] Tab Updates and enhancements Nov 2, 2021
@tay1orjones tay1orjones mentioned this issue Nov 2, 2021
21 tasks
@tay1orjones tay1orjones added this to the v11 Beta 3 milestone Nov 2, 2021
@marceltrautmann

This comment was marked as resolved.

@aagonzales

This comment was marked as resolved.

@marceltrautmann

This comment was marked as resolved.

@aagonzales

This comment was marked as resolved.

@aagonzales

This comment was marked as resolved.

@aagonzales

This comment was marked as resolved.

@marceltrautmann

This comment was marked as resolved.

@aagonzales

This comment was marked as resolved.

@aagonzales
Copy link
Member

aagonzales commented Jan 24, 2022

Talked to Mike in Slack, this is what we concluded for what's allowed with icons in tabs.

image

@tay1orjones
Copy link
Member

I want to provide an update as to the delivery of this. This required quite a bit of unexpected restructuring/foundational work to achieve these design enhancements. @abbeyhrt has completed that work and it will be shipped in v11. It includes contained tabs, line tabs, icon only tabs, and has feature parity (overflow scrolling, etc) with the existing tabs in v10.

The remaining incomplete items do not require a breaking change. These improvements will be revisited post-v11.

  • Default tabs with descriptive icon
  • Dismissible tabs and the related accessibility concerns
  • Dismissible tabs with descriptive icon
  • ContainedTabs secondary label

@tay1orjones
Copy link
Member

To be clear, with the new API in v11 there's nothing blocking the configuration of the above items. Consumers can place their own custom elements, markup, components, etc into Tabs.

The revisiting of the items listed above will be aimed at making it easier to configure these types of tabs correctly out of the box.

@laurenmrice
Copy link
Member

laurenmrice commented Mar 16, 2023

@francinelucca Here is an updated spec of Contained tabs with a secondary label and icon.

Frame 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs epic Special label used by ZenHub for epic functionality package: react carbon-components-react planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖 type: enhancement 💡
Projects
Archived in project
Archived in project
Development

No branches or pull requests

10 participants