Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): update id generation logic #1659

Conversation

joshblack
Copy link
Contributor

This PR should fix an issue in the index where YML files authored in separate maintainer directories overrode each other by updating how we define an id in the GraphQL Schema for each component. Instead of using the file name, it now uses a combination of the maintainer and file.

Changelog

New

Changed

  • Update node id logic for our index plugin

Removed

@vercel
Copy link

vercel bot commented Sep 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/nx2h7f1js
✅ Preview: https://carbondesignsy-git-fork-joshblack-fix-update-index-node-96e989.carbon-design-system.vercel.app

@kodiakhq kodiakhq bot merged commit 3512a03 into carbon-design-system:master Sep 8, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants