Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component-index): 1768 & 1743 component-index-visual-bugs #1826

Merged
merged 6 commits into from
Sep 24, 2020
Merged

fix(component-index): 1768 & 1743 component-index-visual-bugs #1826

merged 6 commits into from
Sep 24, 2020

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Sep 23, 2020 •
edited
Loading

Closes #1768 & #1743

Fixes the following visual issues on the Component Index:

@andreancardona andreancardona requested a review from a team as a code owner September 23, 2020 18:07
@vercel vercel bot temporarily deployed to Preview September 23, 2020 18:07 Inactive
@vercel
Copy link

vercel bot commented Sep 23, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/rbxz2cbez
✅ Preview: https://carbondesignsy-git-fork-andreancardona-1768-component-in-761397.carbon-design-system.vercel.app

@andreancardona andreancardona mentioned this pull request Sep 23, 2020
Closed
50 tasks
aagonzales
aagonzales reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On smaller screens those filter dividers are running off the edge. Can have make sure it has 32px on the edge there. The rest looks great!

image

@andreancardona
Copy link
Contributor Author

re it has 32px on the edge there

Ooops yes doing that now

@vercel vercel bot temporarily deployed to Preview September 23, 2020 18:55 Inactive
@andreancardona
Copy link
Contributor Author

@aagonzales let me know how it looks now!

@vercel vercel bot temporarily deployed to Preview September 23, 2020 19:01 Inactive
aagonzales
aagonzales approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, perfect!

tw15egan
tw15egan approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✅

@kodiakhq kodiakhq bot merged commit 5de14f4 into carbon-design-system:master Sep 24, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @alisonjoseph @natashadecoste
fix(component-index): 1768 & 1743 component-index-visual-bugs (carbon…
8a60c04 
…-design-system#1826)

* fix(component-index): 1768 & 1743 component-index-visual-bugs

* updated spacing

* updated right padding

Co-authored-by: andrea.cardonaibm.com <andrea.cardonaibm.com>
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @alisonjoseph @natashadecoste
fix(component-index): 1768 & 1743 component-index-visual-bugs (carbon…
97d1d2c 
…-design-system#1826)

* fix(component-index): 1768 & 1743 component-index-visual-bugs

* updated spacing

* updated right padding

Co-authored-by: andrea.cardonaibm.com <andrea.cardonaibm.com>
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@aagonzales aagonzales aagonzales approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@aledavila aledavila Awaiting requested review from aledavila

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[index] remaining visual bugs
4 participants
@andreancardona @alisonjoseph @aagonzales @tw15egan