fix(KnobContainer): perform global match for props replacement #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/GTzqCHQZgYsviVNVfuHJZ3WBngUK |
94 tasks
aagonzales
requested changes
May 5, 2021
There was a problem hiding this comment.
The updates are only on the demo in the code tab, they also need to be on the demo on the usage tab as well.
https://carbondesignsy-git-fork-emyarod-2003-date-picker-demo-bu-3a47e9.vercel.app/components/date-picker/usage#live-demo
emyarod
force-pushed
the
2003-date-picker-demo-bugs
branch
from
e288faf
to
33ee8b4
Compare
|
the usage tab should also have the updates now |
aagonzales
reviewed
May 5, 2021
emyarod
force-pushed
the
2003-date-picker-demo-bugs
branch
from
33ee8b4
to
a503f18
Compare
emyarod
force-pushed
the
2003-date-picker-demo-bugs
branch
from
b7b4027
to
4e5e4d3
Compare
dakahn
approved these changes
May 7, 2021
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
…n-design-system#2276) * fix(KnobContainer): perform global match for props replacement * fix(DatePicker): add invalid and size knobs * fix(date-picker): add md size knob
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
…n-design-system#2276) * fix(KnobContainer): perform global match for props replacement * fix(DatePicker): add invalid and size knobs * fix(date-picker): add md size knob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2003
This PR adds
invalidandsizeknobs to the date picker live demosChangelog
Changed
Testing/Reviewing
Confirm that applying/removing knobs in component demos still function as expected and that the date picker demo now contains the missing knobs