Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align status indicator table to grid #2681

Merged
merged 8 commits into from
Jan 18, 2022
Merged

fix: align status indicator table to grid #2681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
991dc9c
fix: align status indicator table to grid
alisonjoseph Jan 5, 2022
938b3d6
fix: align status indicator table to grid
alisonjoseph Jan 5, 2022
735ae5c
fix: align status indicator table to grid
alisonjoseph Jan 5, 2022
6b0b396
fix: align status indicator table to grid
alisonjoseph Jan 5, 2022
cadc20c
chore(status-indicator): add table layout width to force custom styles
Jan 5, 2022
3ebbe22
fix: safari on grid
alisonjoseph Jan 6, 2022
f40ce95
Merge branch 'main' into status-table-alignment
alisonjoseph Jan 11, 2022
c469469
Merge branch 'main' into status-table-alignment
kodiakhq[bot] Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions src/components/StatusIndicatorTable/StatusIndicator.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
.iconGroup {
padding: 1rem;
display: flex;
width: 50%;
width: 100%;

@include carbon--breakpoint('lg') {
width: 50%;
}
}

.iconGroup.isDark {
Expand Down Expand Up @@ -79,16 +83,43 @@
border-bottom: none;
}

@media (max-width: 600px) {
.statusIndicatorTableWrapper {
margin-left: -1rem;
margin-right: -1rem;
}

@include carbon--breakpoint-between('sm', 'lg') {
.statusIndicatorTableWrapper {
margin-right: -1rem;
margin-left: -1rem;
overflow: scroll;
}
.iconGroup {
width: 100%;
}
.iconGroup.isDark {
display: none;
}
}

//Needed for Safari
.statusIndicatorTableWrapper {
@include carbon--breakpoint('md') {
:global(.bx--col-md-1) {
width: 12.5%;
}

:global(.bx--col-md-2) {
width: 25%;
}

:global(.bx--col-md-3) {
width: 37.5%;
}
}

@include carbon--breakpoint('lg') {
:global(.bx--col-lg-4) {
width: 33.333333%;
}

:global(.bx--col-lg-2) {
width: 16.66667%;
}
}
}
12 changes: 6 additions & 6 deletions src/components/StatusIndicatorTable/StatusIndicatorTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ import {
const StatusIndicatorTable = ({ attention }) => (
<div className={statusIndicatorTableWrapper}>
<StructuredListWrapper className={table}>
<StructuredListHead>
<StructuredListRow head>
<StructuredListCell className={headerCell} head>
<StructuredListHead className='bx--grid'>
<StructuredListRow className='bx--row' head>
<StructuredListCell className={`bx--col-lg-4 bx--col-md-1 ${headerCell}`} head>
Icon
</StructuredListCell>
<StructuredListCell className={headerCell} head>
<StructuredListCell className={`bx--col-lg-2 bx--col-md-2 ${headerCell}`} head>
Name
</StructuredListCell>
<StructuredListCell className={headerCell} head>
<StructuredListCell className={`bx--col-lg-2 bx--col-md-2 ${headerCell}`} head>
Token
</StructuredListCell>
<StructuredListCell className={headerCell} head>
<StructuredListCell className={`bx--col-lg-4 bx--col-md-3 ${headerCell}`} head>
Description & usage
</StructuredListCell>
</StructuredListRow>
Expand Down